Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set libpq path for pg_dump in fast_import #10216

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Set libpq path for pg_dump in fast_import #10216

wants to merge 1 commit into from

Conversation

kelvich
Copy link
Contributor

@kelvich kelvich commented Dec 20, 2024

Without that psql uses library from apt package libpq5 which is a transitive dependency of libgdal28 which is needed for postgis extension. And that thing overshadows proper libpq that we install:

postgres@a6bde1e8e89e:~$ ldd `which psql` | grep pq
	libpq.so.5 => /usr/lib/aarch64-linux-gnu/libpq.so.5 (0x0000ffffaf135000)
postgres@a6bde1e8e89e:~$ dpkg-query  -S /usr/lib/aarch64-linux-gnu/libpq.so.5
libpq5:arm64: /usr/lib/aarch64-linux-gnu/libpq.so.5
postgres@a6bde1e8e89e:~$ apt-cache rdepends libpq5
libpq5
Reverse Depends:
  libgdal28
postgres@a6bde1e8e89e:~$ apt show libpq5 | grep -i version
Version: 13.18-0+deb11u1

In theory we could try to clean up image from that old libpq, but IMO it not worth it. Always setting LD_LIBRARY_PATH should be robust enough, and would work for all versions/archs.

@github-actions GitHub Actions
Copy link

7095 tests run: 6798 passed, 0 failed, 297 skipped (full report)

Flaky tests (2)

Postgres 15

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-arm64

Postgres 14

Code coverage* (full report)

  • functions: 31.3% (8400 of 26877 functions)
  • lines: 48.0% (66693 of 139062 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
5325f1e at 2024-12-20T12:51:04.026Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NanoBjorn NanoBjorn NanoBjorn approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelvich @NanoBjorn